fix(contextmenu): uncaught TypeError

[sowo]

SUMMARY

This PR resolves a uncaught TypeError in MixedTimeseries charts with saved metrics.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
Screencast from 04-24-2024 05:16:25 PM.webm

After
Screencast from 04-24-2024 08:09:58 PM.webm

TESTING INSTRUCTIONS

Create a MixedTimeseries chart with using saved metrics. Without the PR, the context menu (right click) will throw an uncaught TypeError exception. With the PR, the context menu works as expected.

ADDITIONAL INFORMATION

• Has associated issue: Uncaught TypeError when opening context menu on MixedTimeseries charts with saved metrics #28199
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[hughhhh]

can we add a small unit test to verify that metric_names will always return properly?

[sowo]

@hughhhh I've added a unit test and some sanity checking. Not sure if the implementation of those checks (https://github.com/sowo/superset/blob/bd0015426aab9ed949259454e36572473b927c39/superset/common/query_context_processor.py#L187 and https://github.com/sowo/superset/blob/bd0015426aab9ed949259454e36572473b927c39/superset/common/query_context_processor.py#L197) is optimal or if there is a better way to handle AdhocColumns and AdhocMetrics. Please advise.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.16%. Comparing base (a1983e4) to head (bd00154).
Report is 183 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #28203       +/-   ##
===========================================
+ Coverage   67.42%   83.16%   +15.74%     
===========================================
  Files        1923      521     -1402     
  Lines       75591    37187    -38404     
  Branches     8443        0     -8443     
===========================================
- Hits        50967    30928    -20039     
+ Misses      22566     6259    -16307     
+ Partials     2058        0     -2058     

Flag	Coverage Δ
hive	49.10% <28.57%> (?)
javascript	?
mysql	77.23% <100.00%> (?)
postgres	77.35% <100.00%> (-0.51%)	⬇️
presto	53.70% <85.71%> (?)
python	83.16% <100.00%> (+5.22%)	⬆️
sqlite	?
unit	58.29% <42.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.