Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(time-comparison-table): change "Display Columns" Text for an Icon #28182

Open
wants to merge 1 commit into
base: table-time-comparison
Choose a base branch
from

Conversation

lilykuang
Copy link
Member

SUMMARY

  • Replace "Display Columns" text with table icon

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2024-04-23 at 10 32 29 AM

After:
Screen Shot 2024-04-23 at 10 28 06 AM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

<div className="col-sm-2" style={{ float: 'right' }}>
<div
className="col-sm-1"
style={{ float: 'right', marginTop: '6px' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we add the styles to a class instead writing it inline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants