Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move supersetbot out of repo #27647

Merged
merged 16 commits into from
Apr 3, 2024
Merged

feat: move supersetbot out of repo #27647

merged 16 commits into from
Apr 3, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 26, 2024

This PR

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (5b1d6b2) to head (a7c6276).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27647      +/-   ##
==========================================
+ Coverage   67.38%   69.72%   +2.33%     
==========================================
  Files        1920     1920              
  Lines       75242    75242              
  Branches     8423     8423              
==========================================
+ Hits        50705    52461    +1756     
+ Misses      22476    20720    -1756     
  Partials     2061     2061              
Flag Coverage Δ
mysql 77.88% <ø> (?)
postgres 77.99% <ø> (ø)
python 82.91% <ø> (+4.83%) ⬆️
sqlite 77.43% <ø> (ø)
unit 56.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch changed the title feat: make supersetbot do what dependabot should do feat: move supersetbot out of repo Apr 2, 2024
@rusackas
Copy link
Member

rusackas commented Apr 2, 2024

Just curious, is this out of necessity, or just easier to work on it? It might be nice to move it back into Superset/ASF control once the dust settles if it's just to make it easier to get things spun up and tested for a while.

@mistercrunch
Copy link
Member Author

Yes the main reason is it doesn't require the same level of scrutiny and rigor as the main repo, and it can have it's own CI/release cycles/tests, .

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable... perhaps one day it can make a grand homecoming or something. I think the main thing is we need docs on the wiki so we can evangelize its use.

@mistercrunch
Copy link
Member Author

Right, it can always move back here once things settle.

@mistercrunch mistercrunch merged commit 8e3cecd into master Apr 3, 2024
31 checks passed
@mistercrunch mistercrunch deleted the pyproject.toml branch April 3, 2024 03:28
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request Apr 4, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code preset-io size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants