fix(bigquery): preserve context buildup - only fetch on last statement #11660
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11660 +/- ##
==========================================
- Coverage 65.61% 62.27% -3.35%
==========================================
Files 873 873
Lines 42315 42313 -2
Branches 3971 3972 +1
==========================================
- Hits 27765 26350 -1415
- Misses 14433 15783 +1350
- Partials 117 180 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -353,9 +354,16 @@ def execute_sql_statements( # pylint: disable=too-many-arguments, too-many-loca | |||
| logger.info("Query %s: %s", str(query_id), msg) | |||
| query.set_extra_json_key("progress", msg) | |||
| session.commit() | |||
There was a problem hiding this comment.
Does this call commit on the cursor? I was thinking in googleapis/python-bigquery#377 that we'd flush any batched queries when a commit was called, but it sounds like this may also not be desirable.
There was a problem hiding this comment.
Oh that's a different session with our metadata database to log the state of the queries, unrelated to the analytics DB
|
Built on false assumptions, closing |
SUMMARY
More details here and in the rabbit hole #11637
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Code should only affect BigQuery, planning on writing a BigQ-specific test