Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support custom service tags and service selection for adapters #2691

Merged
merged 11 commits into from Apr 30, 2024
Merged

feat: Support custom service tags and service selection for adapters #2691

merged 11 commits into from Apr 30, 2024

Conversation

dominikriemer
Copy link
Member

Purpose

The PR introduces dynamic selection of extension services for adapters. Setting an optional new environment variable SP_SERVICE_TAGS assigns a comma-separated list of custom service tags to an extension service. When creating a new adapter, users can provide Deployment Settings by either choosing the option to select a random service the adapter gets deployed to, or they can filter the target service by custom service tags. With this feature, it becomes possible to assign the execution of an adapter to a specific edge device.

image

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added java Pull requests that update Java code ui Anything that affects the UI backend Everything that is related to the StreamPipes backend labels Apr 3, 2024
@dominikriemer dominikriemer marked this pull request as ready for review April 4, 2024 18:36
@github-actions GitHub Actions
Copy link
Contributor

Hello there 👋

We noticed that it's been some time since activity occurred on your pull request 🤔. In order to keep things moving forward, we're marking this PR as stale and giving you 7 days to respond before it's automatically closed ⏰.

Please take a moment to review your pull request and make any necessary updates or changes 👨‍💻. If you need more time or have any questions, please don't hesitate to let us know 💬.

Thank you for your contributions to our project, and we look forward to hearing back from you soon 🙏.

@github-actions github-actions bot added the stale Marks pull requests that are classified as `stale` by our bot. label Apr 26, 2024
@github-actions github-actions bot removed the stale Marks pull requests that are classified as `stale` by our bot. label Apr 30, 2024
bossenti
bossenti approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@bossenti bossenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution @dominikriemer

Is the new Service Selection UI group automatically part of every adapter, pipeline element etc.? Does it default to Any available service?

Do we need a migration for existing StreamPipes instances?

...pes-model/src/main/java/org/apache/streampipes/model/deployment/DeploymentConfiguration.java Outdated
g.getAppId(),
ExtensionsServiceEndpointUtils.getPipelineElementType(g))
.getEndpointResourceUrl();
public class DeploymentConfiguration {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be a record

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And can we rename it to something like ProcessingElementDeploymentConfiguration? Just to make it clear that it has nothing to do with the actual StreamPipes deployment configuration.

...l/src/main/java/org/apache/streampipes/model/extensions/svcdiscovery/SpServiceTagPrefix.java Outdated Show resolved Hide resolved
@dominikriemer
Copy link
Member Author

Great contribution @dominikriemer

Is the new Service Selection UI group automatically part of every adapter, pipeline element etc.? Does it default to Any available service?

Do we need a migration for existing StreamPipes instances?

This PR only supports service selection for adapters (not pipeline elements). There should be no migration required and the feature should work for all adapters. Default is any available service, with the custom selection disabled if there are no services found.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file testing Relates to any kind of test (unit test, integration, or E2E test). labels Apr 30, 2024
@dominikriemer dominikriemer merged commit 0fdd15d into dev Apr 30, 2024
21 checks passed
@dominikriemer dominikriemer deleted the support-service-selection-for-adapters branch April 30, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

@bossenti bossenti bossenti approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend dependencies Pull requests that update a dependency file java Pull requests that update Java code testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dominikriemer @tenthe @bossenti