feat(#232): Support optional free text properties #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java
bossenti
approved these changes
Mar 28, 2024
tenthe
requested changes
Mar 28, 2024
...del/src/main/java/org/apache/streampipes/model/staticproperty/RemoteOneOfStaticProperty.java
Show resolved
Hide resolved
tenthe
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow to mark free text static properties as
optionalso that fields in the adapter and pipeline element configuration panels can be left empty if theoptionalflag is set.We had a field
valueRequiredin the model definition which I have removed since it wasn't used anywhere and defaulted to false, although we currently regard all static properties as required.Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no