Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

phoenix integration with 1.4.6 #10

Open
wants to merge 6 commits into
base: branch-1.4.6
Choose a base branch
from

Conversation

mravi
Copy link

@mravi mravi commented Nov 1, 2015

This PR contains a code patch for importing data into Apache Phoenix tables from SQL.
The following tasks are pending
a) Unit Tests. As the third party tests related to HBase are failing on a fresh checkout from GIT , I couldn't complete writing all the tests.
b) Code Template format. Are there any specific Eclipse Code Template Formats that I should be configuring .
c) Right now the code is built against 1.4.6 v of Sqoop as we have seen users requesting for Sqoop support in Phoenix mailing list. Based on the comments and feedback, I will come up with a patch against master branches.

@gabrielreid
Copy link
Member

Just taking a look through this -- having Phoenix support in Sqoop would be great!

I know that this is an initial cut, but just a few remarks on the code:

  • Around code style:
    • it looks like the general Sqoop convention is to use 2 spaces for indentation, but this code uses 4 spaces
    • the Sqoop code includes a space after an if and before the opening parenthesis, but this code omits that space
  • The PhoenixImportJob class extends the DataDrivenImportJob class in the com.cloudera.sqoop package, but this is deprecated -- I think that it should probably extend the DataDrivenImportJob in the org.apache.sqoop package. Same thing for the imports in that class.

I'll add a couple of other things I noticed as comments in the commits.

@ravimagham
Copy link

Thanks Gabriel Reid. I will make the necessary corrections and have the patch updated to the ticket and open a RB.

artursukhenko pushed a commit to mapr/sqoop that referenced this pull request May 3, 2017
MAPR-23433: sqoop 1.4.6 build is broken
@jqueguiner
Copy link

any update on this matter ?

@sidorenko-clearscale
Copy link

I will be nice to see sqoop to phoenix import.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants