Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8077] Optimize message queue write selector used by proxy #8078

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Apr 30, 2024

Which Issue(s) This PR Fixes

Fixes #8077

Brief Description

  1. Add new MessageQueueReadSelector to extend MessageQueueSelector, using ThreadLocalIndex as write selector index.
  2. Remove unnecessary transferring between MessageQueue and AddressableMessageQueue.

How Did You Test This Change?

UT

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 42.81%. Comparing base (04dddec) to head (e7e4880).
Report is 1 commits behind head on develop.

Files Patch % Lines
...proxy/service/route/MessageQueueWriteSelector.java 71.11% 9 Missing and 4 partials ⚠️
...etmq/proxy/service/route/MessageQueueSelector.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8078      +/-   ##
=============================================
- Coverage      42.85%   42.81%   -0.04%     
+ Complexity     10355    10343      -12     
=============================================
  Files           1270     1271       +1     
  Lines          88677    88680       +3     
  Branches       11398    11396       -2     
=============================================
- Hits           37999    37970      -29     
- Misses         45990    46016      +26     
- Partials        4688     4694       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@redlsz redlsz force-pushed the feature/optimize-message-queue-selector branch from e7e4880 to ae7ae4a Compare April 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the message queue write selector used by proxy
2 participants