Feat/hop #839
Draft
Feat/hop #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Trivy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
…rite and Events are working, Subscription is missing due to S7 driver problems. The resources for modification are added to the portal.
… the corrections in the Hop integration for the correct handling of Actions and Transforms.
|
Your mspec changes shouldn't cause any serious problems ... I'll have a look at if the build works on my machine. I think you can remove the ".cache" files as I think IntelliJ creates them when using the IDE editor ... same with the generated png files. These should be created during the website generation. I love your Toddies by the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with Hop V2.X.X in progress. Action and Transform Read, Write and Events are working, Subscription is missing due to problems in the S7 driver, these routines were removed in version 0.10.0 of Plc4x. The resources for the modification are added to the portal and proceed to their documentation.