feat(eip): update eip driver to include an option for connected messaging. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndyGrebe It'd be great if you could take a look at this PR. A new driver has been added for logix controllers. The connection string format will be something like This should use Little Endian and the Field format now no longer requires a leading %. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| routingAddress.add(new LogicalSegment(new InstanceID((byte) 0, (short) 1, this.configuration.getByteOrder()), this.configuration.getByteOrder())); | ||
|
|
||
| for (PathSegment segment : this.routingAddress) { | ||
| this.connectionPathSize += segment.getLengthInBytes(); |
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment
| this.connectionPathSize += segment.getLengthInBytes(); | ||
| } | ||
| if ((this.connectionPathSize % 2) != 0) { | ||
| this.connectionPathSize += 1; |
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment
…r to look at the endian-ness
…nd or connection manager is available.
…anager is available.
# Conflicts: # plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/readwrite/protocol/EipProtocolLogic.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the EIP driver to include options for Little/Big endian and using connected messaging.