Phoenix 7211 : Identify IT tests that can be run successfully against real distributed cluster #1875
+581
−296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpisaac
reviewed
Apr 9, 2024
|
|
||
| public static String generateUniqueName() { | ||
| int nextName = NAME_SUFFIX.incrementAndGet(); | ||
| if (nextName >= MAX_SUFFIX_VALUE) { | ||
| throw new IllegalStateException("Used up all unique names"); | ||
| } | ||
| TABLE_COUNTER.incrementAndGet(); | ||
| return "N" + Integer.toString(MAX_SUFFIX_VALUE + nextName).substring(1); | ||
| return phoenixTestTableName.getTableName() + "_" + Integer.toString(MAX_SUFFIX_VALUE + nextName).substring(1); |
There was a problem hiding this comment.
Some initial thoughts -
- Maybe we should use the new naming convention (tablename decorated) only for the distributed case.
- Do the regular ITs pass? when not qualified by a category?
Signed-off-by: Jacob Isaac <jisaac@salesforce.com>
… real distributed cluster
jpisaac
reviewed
Apr 23, 2024
| @@ -975,10 +999,54 @@ private static void deletePriorTables(long ts, Connection globalConn, String url | |||
| ResultSet rs = dbmd.getTables(null, null, null, tableTypes); | |||
| String lastTenantId = null; | |||
| Connection conn = globalConn; | |||
| System.out.println("outside"); | |||
There was a problem hiding this comment.
nit: Remember to remove these debug lines
| <configuration> | ||
| <reuseForks>false</reuseForks> | ||
| <argLine>@{jacocoArgLine} -enableassertions -Xmx3000m -Djava.security.egd=file:/dev/./urandom "-Djava.library.path=${hadoop.library.path}${path.separator}${java.library.path}" -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/ -XX:NewRatio=4 -XX:SurvivorRatio=8 -XX:+UseCompressedOops -XX:+UseConcMarkSweepGC -XX:+DisableExplicitGC -XX:+UseCMSInitiatingOccupancyOnly -XX:+CMSClassUnloadingEnabled -XX:+CMSScavengeBeforeRemark -XX:CMSInitiatingOccupancyFraction=68</argLine> | ||
| <groups>org.apache.phoenix.end2end.SupportsDistributedClusterTest</groups> |
There was a problem hiding this comment.
What category is SupportsDistributedClusterTest? How is it different from SuccessfulSupportsDistributedClusterTest?
Or is the intent to use one or the other? In that case I would vote for "SupportsDistributedClusterTest"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.