HDDS-10779. The create pipeline command supports the specified node

[guohao-rosicky]

What changes were proposed in this pull request?

The create pipeline command supports the specified node

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10779

[adoroszlai]

Thanks @guohao-rosicky for the patch.

Can you please describe how it was tested? Checking SCM it seems the list of nodes is ignored at multiple levels.

NodePool is logged, but not passed to createPipeline:

ozone/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java

Lines 731 to 740 in 21fa62f

	if (nodePool != null && !nodePool.getNodesList().isEmpty()) {
	List<String> nodeIpAddresses = new ArrayList<>();
	for (HddsProtos.Node node : nodePool.getNodesList()) {
	nodeIpAddresses.add(node.getNodeID().getIpAddress());
	}
	auditMap.put("nodePool", String.join(", ", nodeIpAddresses));
	}
	try {
	Pipeline result = scm.getPipelineManager().createPipeline(
	ReplicationConfig.fromProtoTypeAndFactor(type, factor));

There is a version of createPipeline that accepts a list of favoredNodes, and passes it on, but in the end PipelinePlacementPolicy ignores it. Only container placement policies use favoredNodes.

CC @sodonnel @swamirishi

[adoroszlai]

/pending Can you please describe how it was tested?

[github-actions]

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

Can you please describe how it was tested?

[github-actions]

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."