HDDS-8802. Added pagination support for ListSnapshotDiff jobs #6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamirishi
reviewed
May 7, 2024
|
|
||
| // If maxEntries are populated and list still has more entries, | ||
| // set the continuation token for the next page request otherwise null. | ||
| if (jobs.size() == maxEntries && iterator.hasNext()) { |
There was a problem hiding this comment.
nit: Do we need the check job.size() == maxEntries ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change is to provide the pagination logic to List SnapshotDiff jobs API.
What is the link to the Apache JIRA
HDDS-8802
How was this patch tested?
Existing unit test and manually tested on docker on local machine.