New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOT tool to send messages to Dweet - https://github.com/apache/openmeetings/issues/102 #103

Open

gkrthk wants to merge 7 commits into apache:master from collisiondetection:dweet

+628 −1

gkrthk commented Jul 26, 2020

This PR contains the WB tool added to send IOT messages to Dweet.
Dweet api integration for send message in wb area.

gkrthk added 5 commits

July 26, 2020 14:51


          add dweet btn in toolbar and open window in wb

b531004


          fix drag and resize popup

7deed34


          dwwet api integration send dweet

e13ecb2


          response section added

11deb7d


          update pop up name

gkrthk mentioned this pull request

IOT tool to send messages to dweet #102

Open

collisiondetection commented Nov 17, 2020

@solomax any thoughts on this ?

Contributor

solomax commented Nov 17, 2020

Hello @gkrthk, @collisiondetection

Unfortunately I had no time (yet) to check this PR (mea culpa)
will try to do it next week
please ping me here next Tuesday

collisiondetection commented Nov 17, 2020

Ok you can check the dweet / message appearing here https://dweet.io/see from OM whiteboard.

collisiondetection commented Nov 20, 2020

collisiondetection commented Dec 1, 2020

@solomax does it seem ok ?

solomax reviewed

View reviewed changes

Contributor

solomax left a comment

What is the purpose to send messages to Dweet?
I mean why would OM users would like to have this new feature?

openmeetings-web/pom.xml Outdated

@@ @@ -163,7 +163,8 @@ @@
               								<jsSourceFile>raw-tool-arrow.js</jsSourceFile>
               								<jsSourceFile>raw-tool-clipart.js</jsSourceFile>
               								<jsSourceFile>raw-wb-board.js</jsSourceFile>
-              								<jsSourceFile>raw-wb-area.js</jsSourceFile>
+              								<jsSourceFile>raw-wb-area.js</jsSourceFile>

Contributor

solomax Dec 2, 2020

please do not create trailing spaces

Author

gkrthk Dec 7, 2020

Done

openmeetings-web/pom.xml Outdated

@@ @@ -264,7 +265,7 @@ @@
               							<jsEngine>CLOSURE</jsEngine>
               							<jsTargetDir>../generated-sources/main/java/org/apache/openmeetings/web/user/chat</jsTargetDir>
               						</configuration>
-              					</execution>
+              					</execution>

Contributor

solomax Dec 2, 2020

please do not create trailing spaces

Author

gkrthk Dec 7, 2020

Done

openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.properties.xml

               	<entry key="wizard.button.finish"><![CDATA[Finish]]></entry>
               	<entry key="zoom.FULL_FIT"><![CDATA[Full-Fit]]></entry>
               	<entry key="zoom.PAGE_WIDTH"><![CDATA[Page Width]]></entry>
+              	<entry key="wb.tool.dweet"><![CDATA[Dweet IOT Messaging]]></entry>
+              	<entry key="wb.tool.dweet.mything"><![CDATA[MyThing]]></entry>

Contributor

solomax Dec 2, 2020

It is not clear what MyThing should mean

collisiondetection Dec 4, 2020

"MyThing " is the term used by Dweet for an object ( fridge, light ) to be controlled.

To make this clearer for the user we could add an example object in the text field: MyThing: ..Light ...........

openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-board.js Outdated

@@ @@ -369,6 +370,52 @@ var Wb = function() { @@
               					minHeight: 140
               					, minWidth: 255
               				});
+              				tools.find('.om-icon.dweet').click(function(){
+              			        dweet = OmUtil.tmpl("#wb-dweet");

Contributor

solomax Dec 2, 2020

OmUtil.tmpl accepts new id as second parameter
please use single quotes for strings

Author

gkrthk Dec 7, 2020

Done

openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-board.js Outdated

@@ @@ -369,6 +370,52 @@ var Wb = function() { @@
               					minHeight: 140
               					, minWidth: 255
               				});
+              				tools.find('.om-icon.dweet').click(function(){
+              			        dweet = OmUtil.tmpl("#wb-dweet");
+              			       	dweet[0].id='wb-dweet' + dweetIDCount++;

Contributor

solomax Dec 2, 2020

It is no clear why element ID should be different every time user role is changed

Author

gkrthk Dec 7, 2020

Everytime the user clicks on the dweet button a new dweet popup will be opened. One user can have multiple dweet popup's opened to control different IOT things. So giving each popup a unique id so that on submit can handle the specific popup action.

openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-board.js Outdated

+              				tools.find('.om-icon.dweet').click(function(){
+              			        dweet = OmUtil.tmpl("#wb-dweet");
+              			       	dweet[0].id='wb-dweet' + dweetIDCount++;
+              			        dweet[0].style.bottom = '100px';

Contributor

solomax Dec 2, 2020

styles should go to CSS

Author

gkrthk Dec 7, 2020

Done

openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-board.js Outdated

+              			       	dweet[0].id='wb-dweet' + dweetIDCount++;
+              			        dweet[0].style.bottom = '100px';
+              			        dweet[0].style.position= 'absolute';
+              			        dweet[0].style[(Settings.isRtl ? 'left' : 'right')] = '100px';

Contributor

solomax Dec 2, 2020

this Settings.isRtl ? 'left' : 'right' code is obsolete
alignment will be changed automatically in case of RTL

Author

gkrthk Dec 7, 2020

Done

openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-board.js Outdated

+              					, minWidth: 255
+              				});
+              				dweet.find('.update-btn').button().click(function() {
+              					var id = $(this.parentElement.parentElement).attr('id');

Contributor

solomax Dec 2, 2020

please use let or const instead of var

Author

gkrthk Dec 7, 2020

Done

openmeetings-web/src/main/webapp/css/custom.css Outdated

		@@ -1 +1,20 @@
		/* Licensed under the Apache License, Version 2.0 (the "License") http://www.apache.org/licenses/LICENSE-2.0 */
		.room-block .sb-wb .wb-block .tools .om-icon.big.dweet::before {

Contributor

solomax Dec 2, 2020

custom.css is for users
OM CSS should go to correspondent raw-*.css files (most probably to raw-wd.css)

Author

gkrthk Dec 7, 2020

Done

openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/dweet-io.js

+              	var request;
+              	var LAST_THING_NAME = "last-thing.dat";
+              	var DWEET_SERVER = "https://dweet.io:443";

Contributor

solomax Dec 2, 2020

I doubt connection to external server will be allowed by CSP

collisiondetection Dec 4, 2020

During our testing on a live site we did not experience any issues with this.

collisiondetection commented Dec 4, 2020

What is the purpose to send messages to Dweet?
I mean why would OM users would like to have this new feature?

The purpose is to be able to control any object such as an arduino. This will allow students to control robots or doctors to control robot arms. It will allow OM to become an interface to any device that can respond to a dweet.

gkrthk added 2 commits

December 7, 2020 23:08


          comments incorporated

a68e7af


          incorporate comments

fd14c0e

collisiondetection commented May 14, 2021

@solomax If I upgrade this to work with current OM can you merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment