Remove keyboard shortcut from terminal close action

[neilcsmith-net]

Remove keyboard shortcut from terminal close action due to multiple conflicts.

While testing the dashboard on macOS I noticed that the terminal close action shortcut clashes with the new dashboard action, which sometimes causes issues. The terminal action uses a non-portable registration, and I was going to look at whether this should change. However, while testing I noticed that the binding on Linux and Windows also clashes with the close all documents action.

As this shortcut seems to only work sporadically, often does nothing, and sometimes inadvertently closes all your open documents instead, it seems a good idea to remove it (for now).

Anyone desperate for keyboard control can always remap, or type exit! 😄

[mbien]

close focused terminal and close all documents should probably not be on the same binding, I agree.

[neilcsmith-net]

close focused terminal ...

Let's call that maybe close focused terminal. Not sure why as yet, but running through in the debugger a lot of times the right action is invoked, but it fails to close anything because isVisibleInContainer is false at https://github.com/apache/netbeans/blob/master/ide/terminal.nb/src/org/netbeans/modules/terminal/ioprovider/Terminal.java#L732 That's a separate issue to having a duplicate key binding, but does show that having no key binding isn't much of an issue either.

Thanks @mbien