Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Go Lexer/Parser for Go Lang 1.20 #7269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lkishalmi
Copy link
Contributor

Updated the GoLang grammar from the ANTLR4 Repo, it supports Go 1.20 which has a new ~ operator.

@lkishalmi lkishalmi added the Go Go Language label Apr 14, 2024
@lkishalmi lkishalmi added this to the NB22 milestone Apr 14, 2024
golang.grammar.version=bcc9ec1b35e4ede2f90abdb8713a56315a634a92

# Simple language update can result too many signature changes in the generated code.
sigtest.skip.gen=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop the pretense that this is module has an API and require that users make dependencies implementation dependencies?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Although I'm also curious why this is a module at all?

@ebarboni ebarboni modified the milestones: NB22, NB23 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go Go Language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants