Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use javac release option where possible #7247

Merged
merged 1 commit into from May 24, 2024
Merged

Conversation

mbien
Copy link
Member

@mbien mbien commented Apr 5, 2024

part 2 of #7188, this is for NB 23

changes here are only for modules which don't use nb-javac, but if #7201 is merged this could update more.

@mbien mbien added do not merge Don't merge this PR, it is not ready or just demonstration purposes. ci:no-build [ci] disable CI pipeline labels Apr 5, 2024
@mbien mbien added this to the NB23 milestone Apr 5, 2024
@mbien mbien added build and removed do not merge Don't merge this PR, it is not ready or just demonstration purposes. ci:no-build [ci] disable CI pipeline labels May 20, 2024
doesn't include modules which use nb-javac
@mbien mbien force-pushed the use-release-flag branch 2 times, most recently from cabf9a9 to 2b114b3 Compare May 20, 2024 05:19
@mbien mbien marked this pull request as ready for review May 20, 2024 05:22
@mbien
Copy link
Member Author

mbien commented May 21, 2024

Opening this branch in NB 22 rc4 shows no error markers, so it seems to be working.

@mbien
Copy link
Member Author

mbien commented May 24, 2024

we can probably merge this now since devs are now able to switch to the NB22 release while working on netbeans

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you!

@mbien mbien merged commit b6cf63e into apache:master May 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants