nimble/host: Zero initialize buffer after allocation #1687
Conversation
rahult-github
force-pushed
the
bugfix/memset_allocated_mem
branch
2 times, most recently
from
6b954aa
to
e9be212
Compare
|
@andrzej-kaczmarek , @sjanc , please take a look |
|
Hi, Does this fix any use of uninitialized memory or is just a precaution? As for style, please use sizeof(*foo) syntax |
Currently , just precaution, since i didn't find any issue as such during my testing. But in many places in nimble, such memset is already existing, hence added at places where it is missing. For style, sure, will change and re-push |
rahult-github
force-pushed
the
bugfix/memset_allocated_mem
branch
from
e9be212
to
da6c8ca
Compare
rahult-github
force-pushed
the
bugfix/memset_allocated_mem
branch
from
da6c8ca
to
4267aa1
Compare
|
Hello @sjanc , please take a look |
There was a problem hiding this comment.
I'm not sure about this patch, most are memseting places that already initialize all fields afterwards, and some of them are frequently called, add extra overhead o function call for no little benefit
maybe we should memset (or explicitly initialized members) only where it is really needed?
At many places , after getting buffer using os_memblock_get, buffer is not zero initiatlized. Added change to memset the same to 0.