nimble/audio: Add Audio Broadcast Sink initial implementation #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariuszSkamra
force-pushed
the
broadcast_sink
branch
6 times, most recently
from
40bc8f0
to
5746199
Compare
MariuszSkamra
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KKopyscinski
reviewed
Feb 2, 2024
KKopyscinski
reviewed
Feb 8, 2024
nimble/host/src/ble_hs_hci_evt.c
Outdated
| static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_create_big_complete; | ||
| static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_terminate_big_complete; | ||
| #endif | ||
| #if MYNEWT_VAL(BLE_ISO_BROADCAST_SINK) | ||
| static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_extablished; |
There was a problem hiding this comment.
Suggested change
| static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_extablished; | |
| static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_established; |
typo :)
KKopyscinski
reviewed
Feb 8, 2024
| enum ble_audio_bsnk_sync_state state; | ||
|
|
||
| /** BIS Synchronization */ | ||
| uint32_t bis_sync; |
There was a problem hiding this comment.
I think this should be an array - probably pointer with count of entries (subgroups)
MariuszSkamra
force-pushed
the
broadcast_sink
branch
from
5746199
to
048498a
Compare
MariuszSkamra
force-pushed
the
broadcast_sink
branch
from
048498a
to
8279cae
Compare
MariuszSkamra
commented
Mar 18, 2024
MariuszSkamra
force-pushed
the
broadcast_sink
branch
3 times, most recently
from
0b4efd2
to
e5fec9e
Compare
| @@ -536,17 +536,8 @@ struct ble_audio_broadcast_name { | |||
| /** BLE Audio event: BASS - Remote Scan Started */ | |||
| #define BLE_AUDIO_EVENT_BASS_REMOTE_SCAN_STARTED 4 | |||
|
|
|||
| /** BLE Audio event: BASS - Add Source */ | |||
There was a problem hiding this comment.
What's the reason to remove these events? I guess the upper layer knows that some actions were performed because the action callback will be called, but this callback is not mandatory. So if the operation was accepted autonomously, there will be no feedback for upper layer/app. For example, we could never enter here:
e5a346b#diff-b8c009ce2010b2473424d883cd93e8fe365b1c1af565ad8ba875280fd069133cR324
There was a problem hiding this comment.
not applicable
MariuszSkamra
force-pushed
the
broadcast_sink
branch
11 times, most recently
from
31b2fb7
to
e344999
Compare
MariuszSkamra
force-pushed
the
broadcast_sink
branch
from
e344999
to
cc423ad
Compare
MariuszSkamra
force-pushed
the
broadcast_sink
branch
2 times, most recently
from
3c15b4e
to
dcbc798
Compare
MariuszSkamra
force-pushed
the
broadcast_sink
branch
from
dcbc798
to
255892f
Compare
rymanluk
reviewed
May 16, 2024
| uint32_t presentation_delay; | ||
|
|
||
| /** Pointer to Maximum Subevents value to initialize. */ | ||
| uint8_t *out_mse; |
There was a problem hiding this comment.
We should add NSE and BN here so application has any means to choose out_MSE.
Also we should set default to 0x00 which means controller can choose up to NSE
rymanluk
reviewed
May 16, 2024
| uint8_t *out_mse; | ||
|
|
||
| /** Pointer to Sync Timeout value to initialize. */ | ||
| uint16_t *out_sync_timeout; |
There was a problem hiding this comment.
Lets add comment about minimum and also set default here:
BIG_Sync_Timeout set by the Host is less than 6 × ISO_Interval, the
Controller shall set the timeout to 6 × ISO_Interval
ea5fd34
to
d65b611
Compare
This adds initial implementation of audio broadcast sink.
this extends the btshell application with Audio Broadcast Sink functionality.
This enables PACS when Broadcast Sink role is enabled. By default the 16_2 and 24_2 mandatory settings are supported as per spec.
MariuszSkamra
force-pushed
the
broadcast_sink
branch
from
d65b611
to
218617d
Compare
|
Fixed missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1691