Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signed Write support #1672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Signed Write support #1672

wants to merge 1 commit into from

Conversation

Singh-Sumeet
Copy link

This PR aims to:

  1. Add support for sending signed write commands
  2. Add support of receiving signed write commands

@Singh-Sumeet
Copy link
Author

@sjanc PTAL

@sjanc
Copy link
Contributor

sjanc commented Jan 5, 2024

Hi,

Few general things (I'll have more detailed comments after doing full code review)

  1. add support for this in bttester (and maybe btshell)
  2. test it with PTS (eg via autopts (https://github.com/auto-pts/auto-pts))
  3. Commit message (title and body) needs improvements
  4. Maybe this should gracefully fallback to Write Without Response if link is encrypted? (just a thought, I'm fine with returning error as is now)

In general I'm bit reluctant about adding this feature as it is barely used (TBH I've never seen this being used in real applications and have not seen any profile that would require it).

But if you need it and above steps are completed I'm not going to block it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Singh-Sumeet @sjanc @SumeetSingh19