host/ble_gap.c : Check allowed random address #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahult-github
force-pushed
the
bugfix/validate_random_address
branch
4 times, most recently
from
a6f07a0
to
310d741
Compare
rahult-github
force-pushed
the
bugfix/validate_random_address
branch
from
310d741
to
72156d6
Compare
|
Hi @sjanc , can you please review this change. |
|
I think this should be in some common code eg ble_hs_id.c ? Some helpers for generating and internal helpers for validating type of addresses. |
rahult-github
force-pushed
the
bugfix/validate_random_address
branch
from
72156d6
to
395f404
Compare
Thanks for the review . I have made a generic function to check if passed address is as per spec or not. |
Add a check to validate whether the random address being set is allowed as per spec
rahult-github
force-pushed
the
bugfix/validate_random_address
branch
from
395f404
to
82660af
Compare
|
@sjanc , Please let me know if you have any more suggestions / comments. |
|
@sjanc ping |
|
Hi @sjanc , please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to validate whether the random address being set is allowed as per spec