nmxact: enable upload cancel by target device #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2021
Signed-off-by: Mateo Ligne <mateo.ligne@netatmo.com>
mateo-ligne-netatmo
force-pushed
the
mli/cancel_image_upload_from_target
branch
from
88d524e
to
a921251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This small PR deals with being able to stop an image upload from the target device by sending a specific return code (I defined 10 to be coherent with newtmgr.h). It is linked with following MCUboot PR that will enable to block firmware update if the incoming firmware version is strictly inferior than stored one's but it can be extended to other use cases.
Do not hesitate to express feedbacks or suggest modifications, I am new to this repository and go language.
Thank you,
Matéo