Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: Add private includes only to specific packages #554

Merged
merged 1 commit into from Apr 16, 2024
Merged

builder: Add private includes only to specific packages #554

merged 1 commit into from Apr 16, 2024

Conversation

m-gorecki
Copy link
Contributor

Instead of adding private includes paths to every package we should add them to the specific packages

@m-gorecki
builder: Add private includes only to specific packages
b28ea19 
Instead of adding private includes paths to every package
we should add them to the specific packages
kasjer
kasjer approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes build of blemesh_models_example_2 when bootutils are included by bsp or startup code.
common.h present in application src folder does not conflict with mbedtls common.h include

@sjanc sjanc merged commit 0ce1291 into apache:master Apr 16, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc sjanc approved these changes

@kasjer kasjer kasjer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m-gorecki @sjanc @kasjer