Free a useless buffer.

apache · Apr 18, 2024 · df98d09 · df98d09
1 parent 62643fe
commit df98d09
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/mina-core/src/main/java/org/apache/mina/filter/codec/CumulativeProtocolDecoder.java b/mina-core/src/main/java/org/apache/mina/filter/codec/CumulativeProtocolDecoder.java
@@ -169,6 +169,12 @@ public void decode(IoSession session, IoBuffer in, ProtocolDecoderOutput out) th
                 buf = newBuf;
 
                 // Update the session attribute.
+                IoBuffer oldBuf = (IoBuffer) session.getAttribute(BUFFER);
+
+                if (oldBuf != null) { 
+                    oldBuf.free();
+                }
+
                 session.setAttribute(BUFFER, buf);
             }
         } else {
@@ -236,6 +242,7 @@ public void dispose(IoSession session) throws Exception {
 
     private void removeSessionBuffer(IoSession session) {
         IoBuffer buf = (IoBuffer) session.removeAttribute(BUFFER);
+
         if (buf != null) {
             buf.free();
         }
@@ -247,6 +254,12 @@ private void storeRemainingInSession(IoBuffer buf, IoSession session) {
         remainingBuf.order(buf.order());
         remainingBuf.put(buf);
 
+        IoBuffer oldBuf = (IoBuffer) session.getAttribute(BUFFER);
+
+        if (oldBuf != null) {
+            oldBuf.free();
+        }
+
         session.setAttribute(BUFFER, remainingBuf);
     }
 

diff --git a/mina-core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java b/mina-core/src/main/java/org/apache/mina/filter/codec/ProtocolCodecFilter.java
@@ -273,6 +273,8 @@ public void messageReceived(final NextFilter nextFilter, final IoSession session
                 }
             }
         }
+
+        in.free();
     }
 
     /**