[MDEP-923] Extract copyFile method from AbstractDependencyMojo #389
Conversation
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
MDEP-923-copyFile
branch
from
7b3f845
to
8fcd200
Compare
| @@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws MojoExecutionException | |||
| assertFalse(handle.isMarkerSet()); | |||
| } | |||
|
|
|||
| public void testCopyFile() throws MojoExecutionException, IOException { | |||
| public void testCopyFile() throws Exception { | |||
There was a problem hiding this comment.
did this change to throw a raw exception? Otherwise it's better to declare the actual exceptions instead of the common superclass.
There was a problem hiding this comment.
It is a Unit Test ... all other methods simply throws Exception
There was a problem hiding this comment.
I like to know when an exception is added or removed from an API, and I'd make the same comment about the other methods in this class. :-)
There was a problem hiding this comment.
ok, one exception is new in 3.7.0 but one is old from copied class - so should I discovered versions for original class or add since now
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java
Outdated
Show resolved
Hide resolved
this method is only needed in CopyMojo and CopyDependenciesMojo so it is not needed in AbstractDependencyMojo
slawekjaranowski
force-pushed
the
MDEP-923-copyFile
branch
from
8fcd200
to
bf0081e
Compare
| @@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws MojoExecutionException | |||
| assertFalse(handle.isMarkerSet()); | |||
| } | |||
|
|
|||
| public void testCopyFile() throws MojoExecutionException, IOException { | |||
| public void testCopyFile() throws Exception { | |||
There was a problem hiding this comment.
I like to know when an exception is added or removed from an API, and I'd make the same comment about the other methods in this class. :-)
this method is only needed in CopyMojo and CopyDependenciesMojo so it is not needed in AbstractDependencyMojo