[KARAF-7325] Support custom properties to simplify adjustment of assemblies #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional files. Signed-off-by: Łukasz Dywicki <luke@code-house.org>
splatch
changed the title
Signed-off-by: Łukasz Dywicki <luke@code-house.org>
|
Ooh, I realize this is languishing in PRs, but it would be really handy if it could be included. |
|
Dang, its quite aged PR, indeed it deserves a push. I'll book some time to update docs to make it clear for end users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a small adjustments in regular expressions, in all places I found related to it, so they work properly with additional properties mentioned in KARAF-7325.
All integration tests pass without failure meaning that change should be harmless to standardized deployments while opening window of opportunity to everyone who needs a slight adjustment of boot packages, system packages or custom capabilities. This should also allow a simpler patching of jre properties for these who need such thing.