object passed for parameter instead of string

[salmansharifov]

Description

Motivation and Context

#5922

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.

[vlsi]

I guess you'll need to add JMeterProperty handling to org.apache.jorphan.util.Converter#getInt(java.lang.Object), getLong, and similar relevant methods.

[salmansharifov]

Like that?

 public static int getInt(JMeterProperty o) {
        Object objectValue = o.getObjectValue();
        return getInt(objectValue, 0);
    }

[vlsi]

not really. Something like

... getInt(...){
if (value instanceof JMeterProperty) {
    return value.getIntegerValue();
}

[salmansharifov]

adding :src:core dependency to :src:jorphan for JMeterProperty cause cyclic dependency error. Is there way to tackle this?

[vlsi]

Oh, I did not think about it.

One of the options could be: make intproperty implement Number.

An alternative option could be adding a custom interface to jorphan that could be implemented in jmeterproperty

[salmansharifov]

Sorry, but I couldn't handle the solution. Do you know any resource for interface solution?

[vlsi]

One of the ways would be add a converter in :src:core so it would try convert the properties first, and if the element is not a property, then delegate to the converter in jorphan.

WDYT?