Deprecate getHeaderManager and setHeaderManager in HTTPSamplerBase #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
deprecate_sethttpmanager
branch
from
f8782c8
to
475e929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See #727
getHeaderManagerandsetHeaderManagerallow too broad API, and they effectively prevent sharing header managers between threads.HTTP Header Manager is a non-trivial object, and it might consume a lot of memory (e.g. if each HTTP Sampler has a Header Manager), so it would be nice to reuse HTTP Headers somehow.
At least, the mechanics of
setHeaderManagerautomatically clones and merges the elements look suspicious.