[INLONG-9010][Sort] Add hive connector for flink1.15 #9030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @huasiy, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍
dockerzhang
changed the title
|
Please add some tests on this connector thx |
vernedeng
reviewed
Oct 12, 2023
| <thrift.version>0.9.3</thrift.version> | ||
| <kafka-clients.version>2.7.1</kafka-clients.version> | ||
| <flink-connector-debezium.version>2.3.0</flink-connector-debezium.version> | ||
| <flink-connector-hive.version>2.12</flink-connector-hive.version> |
There was a problem hiding this comment.
What is this version used for
vernedeng
reviewed
Oct 12, 2023
| @@ -52,9 +52,11 @@ | |||
| <flink.protobuf.version>2.7.6</flink.protobuf.version> | |||
| <sqlserver.jdbc.version>7.2.2.jre8</sqlserver.jdbc.version> | |||
| <hudi.version>0.12.3</hudi.version> | |||
| <hive.version>3.1.3</hive.version> | |||
There was a problem hiding this comment.
hive3 version property has been defined in root pom
vernedeng
reviewed
Oct 12, 2023
|
|
||
| @Override | ||
| public String factoryIdentifier() { | ||
| return HiveCatalogFactoryOptions.IDENTIFIER; |
There was a problem hiding this comment.
Use IDENTIFIER "hive-inlong"
vernedeng
reviewed
Oct 12, 2023
| @@ -31,49 +31,47 @@ | |||
|
|
|||
| <properties> | |||
| <inlong.root.dir>${project.parent.parent.parent.parent.basedir}</inlong.root.dir> | |||
| <hive.version>3.1.3</hive.version> | |||
There was a problem hiding this comment.
No need to define duplicated hive version properties
|
This PR is stale because it has been open for 60 days with no activity. |
github-actions
bot
added
the
stage/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation