Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10215][DashBoard] Add default value for file data source in data access module #10216

Merged
merged 3 commits into from
May 14, 2024

Conversation

wohainilaodou
Copy link
Contributor

@wohainilaodou wohainilaodou commented May 14, 2024

Fixes #10215

Motivation
Add default value for the file data source in a data access module

Modifications
Add default values ​​to the maximum number of files, period, and offset properties of the file data source in the data access module

Verifying this change

Verifying this change

image

image

haifxu
haifxu previously approved these changes May 14, 2024
@aloyszhang aloyszhang changed the title [INLONG-10215][DashBoard] Add default value for file data source in d… [INLONG-10215][DashBoard] Add default value for file data source in data access module May 14, 2024
Copy link
Contributor

@justinwwhuang justinwwhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit 974ef70 into apache:master May 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][DashBoard] Add default value for file data source in data access module
4 participants