Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10017][Sort] Add the definition of Sort Config #10018

Merged
merged 7 commits into from
Apr 21, 2024

Conversation

vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Apr 18, 2024

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

To unify the Sort Config of SortStandalone and SortFlink, we propose a new protocol to describe the configuration hierarchy of Sort.

This issue is about the definition of a set of POJOs.

The precondition of #9867

Modifications

The format definitions are moved to inlong-common dictionary.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng self-assigned this Apr 18, 2024
luchunliang
luchunliang previously approved these changes Apr 19, 2024
@dockerzhang dockerzhang changed the title [INLONG-10017][Sort] Definition of Sort Config [INLONG-10017][Sort] Add the definition of Sort Config Apr 19, 2024
dockerzhang
dockerzhang previously approved these changes Apr 19, 2024
@fuweng11 fuweng11 marked this pull request as draft April 19, 2024 03:13
@vernedeng vernedeng marked this pull request as ready for review April 20, 2024 03:08
fuweng11
fuweng11 previously approved these changes Apr 20, 2024
@dockerzhang dockerzhang merged commit 33b4ca9 into apache:master Apr 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Definition of Sort Config
5 participants