Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dist): support docker deployment for PD and Store #2529

Merged
merged 11 commits into from May 18, 2024
Merged

feat(dist): support docker deployment for PD and Store #2529

merged 11 commits into from May 18, 2024

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Apr 21, 2024 •
edited

@VGalaxies VGalaxies self-assigned this Apr 21, 2024
@VGalaxies VGalaxies added ci-cd Build or deploy pd PD module store Store module labels Apr 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2024 •
edited by codecov bot

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pd-store@4c6eda8). Learn more about missing BASE report.

Additional details and impacted files 
@@             Coverage Diff             @@
##             pd-store    #2529   +/-   ##
===========================================
  Coverage            ?   48.51%           
  Complexity          ?      827           
===========================================
  Files               ?      717           
  Lines               ?    58366           
  Branches            ?     7489           
===========================================
  Hits                ?    28315           
  Misses              ?    27217           
  Partials            ?     2834

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin added this to the 1.5.0 milestone Apr 22, 2024
@VGalaxies VGalaxies marked this pull request as ready for review April 25, 2024 13:21
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature New feature labels Apr 25, 2024
@imbajin imbajin requested review from coderzc and liuxiaocs7 May 6, 2024 12:09
imbajin
imbajin reviewed May 17, 2024
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, we have too much similar config files 😢

hugegraph-server/Dockerfile Outdated Show resolved Hide resolved
hugegraph-pd/Dockerfile Outdated Show resolved Hide resolved
docker/configs/server3-conf/hugegraph-server.keystore Outdated Show resolved Hide resolved
imbajin
imbajin approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it first (as a preview version)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 18, 2024
@VGalaxies VGalaxies merged commit e1bd708 into pd-store May 18, 2024
16 of 17 checks passed
@VGalaxies VGalaxies deleted the pd-store-docker branch May 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@coderzc coderzc Awaiting requested review from coderzc

@liuxiaocs7 liuxiaocs7 Awaiting requested review from liuxiaocs7

Assignees

@VGalaxies VGalaxies

Labels
ci-cd Build or deploy feature New feature lgtm This PR has been approved by a maintainer pd PD module size:XXL This PR changes 1000+ lines, ignoring generated files. store Store module
Projects
HugeGraph PD-Store Tasks
Status: Done
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VGalaxies @codecov-commenter @imbajin