IGNITE-21568 Java thin: Pass client time zone to server #3737
Conversation
| if (timeZoneId != null) { | ||
| builder.set(QueryProperty.TIME_ZONE_ID, ZoneId.of(timeZoneId)); | ||
| } |
There was a problem hiding this comment.
How are we going to specify or reference the timezone format in other clients? Just give a reference to java.time.ZoneId javadocs?
There was a problem hiding this comment.
Yes, the javadoc explains it in detail: ZoneId#of
It supports standard IANA region-based zone IDs, so I expect every client to have something suitable in the standard library or a popular package.
| @@ -31,14 +31,20 @@ public class ClientStatement implements Statement { | |||
| private final String query; | |||
|
|
|||
| /** Default schema. */ | |||
| @Nullable | |||
There was a problem hiding this comment.
according to our coding guidelines, type-use annotations appear immediately before the annotated type. Please fix it in other places too
There was a problem hiding this comment.
Fixed.
I've used javax.annotation.Nullable instead of org.jetbrains.annotations.Nullable by mistake, and the IDE displays a warning about incorrect order in that case.
No description provided.