Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-21946: Cover SQL F863(Nested <result offset clause> in <query expression>) feature by tests #3732

Merged
merged 14 commits into from May 14, 2024

Conversation

lowka
Copy link
Contributor

@lowka lowka commented May 10, 2024

  • Adds test cases for SQL F863(Nested result offset clause in query expression)
  • Moved test_union to set
  • Assigned proper group name to set operation tests.
  • Disables buggy remove sort in subquery flag (adds limit offset planner to ensure that planner produces correct plans) - (see https://issues.apache.org/jira/browse/CALCITE-4323)

https://issues.apache.org/jira/browse/IGNITE-21946


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@lowka lowka force-pushed the ignite-21946 branch 3 times, most recently from 41f59c0 to 6b62486 Compare May 12, 2024 11:46
@zstan
Copy link
Contributor

zstan commented May 14, 2024

honestly i don`t know why do we need planner tests here, let`s wait @ygerzhedovich thoughts.
In my opinion planner tests can test propagated parameters or for example cases like awaiting predicates in scan node but describe one of possible plans is no good idea, as for me.

@ygerzhedovich ygerzhedovich merged commit 755a840 into apache:main May 14, 2024
1 check passed
@ygerzhedovich ygerzhedovich deleted the ignite-21946 branch May 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants