Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-20294: Sql. Using UDF as a place for system_range function #3729

Merged
merged 2 commits into from May 15, 2024

Conversation

lowka
Copy link
Contributor

@lowka lowka commented May 9, 2024

Provides implementation of a table function that does not store its state inside SQL row.

  • ScanNode now uses TableFunction instead of an iterable.
  • Every scan creates a new instance of table function, and then uses it to produce more rows. When scan completes that instance is closed.

TableFunction - some table function.
TableFunctionInstance - concrete implementation of a table function (Scan operator creates an instance of table function per scan.
TableFunctionRegistry (for a lack of a better name) converts RexCalls into TableFunctions

https://issues.apache.org/jira/browse/IGNITE-20294


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@lowka lowka force-pushed the ignite-20294_table_func branch from 6e1f7bc to 51b473f Compare May 9, 2024 12:33
@lowka lowka force-pushed the ignite-20294_table_func branch from 51b473f to 54ab634 Compare May 9, 2024 14:21
@xtern xtern merged commit 3cb6be9 into apache:main May 15, 2024
1 check passed
@xtern xtern deleted the ignite-20294_table_func branch May 15, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants