IGNITE-20294 Sql. Using UDF as a place for system_range function #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
reviewed
Apr 29, 2024
|
|
||
| /** Creates a {@link org.apache.calcite.schema.impl.TableFunctionImpl} from a class, looking for an "eval" | ||
| * method. Returns null if there is no such method. */ | ||
| public static @Nullable TableFunction create(Class<?> clazz) { |
There was a problem hiding this comment.
why do we need this method (and the following)?
p.s. I see "for eval" but can't figure out what's not working 😔
| * @param name name of the method to find | ||
| * @return the first method with matching name or null when no method found | ||
| */ | ||
| static @Nullable Method findMethod(Class<?> clazz, String name) { |
There was a problem hiding this comment.
is it possible to use this method in RexToLixTranslator and remove the same method from RexToLixTranslator?
or move it to some utility-class?
lowka
reviewed
Apr 30, 2024
| super( | ||
| "SYSTEM_RANGE", | ||
| new SqlIdentifier(funcName, SqlParserPos.ZERO), |
There was a problem hiding this comment.
What is a point of making a function name configurable, if this function can only used for a system range function?
| * Implementation of {@link org.apache.calcite.schema.TableFunction} based on a | ||
| * method. | ||
| */ | ||
| public class TableFunctionImpl extends ReflectiveFunctionBase |
There was a problem hiding this comment.
Why this one is copied? How it differs from calcite's TableFunctionImpl?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes