New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-21805 Refactor TableManager and move all RAFT related pieces to Replica #3633
base: main
Are you sure you want to change the base?
Conversation
…leManager, also groupOptionsForPartition is removed due to no usage
…ice at first, before replica will be created
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java
Outdated
Show resolved
Hide resolved
…lica methods are removed.
A comment about a test's fix there: before the ticket there wasn't |
…antiation into ReplicaManager; Rebalance scheduled executor and VolatileLogStorageFactoryCreator are moved too from TableManager
…changing replicas' starting condition on substraction between pending and stable assignments
…ondition before replica starting
…d return statement now is common
…d return statement now is common
…on method in ReplicaManager
…nd replica starting
…RaftClient in TableManagerRecoveryTest#startComponents and TableManagerTest#before
…SkipReplicaStarting flag
…d moving back reset peers from startReplica to TableManager
Apache JIRA ticket's link
The goal
The goal of this PR is to remove
RaftManager
fromTableManager
and place it and its calls toReplicaManager
.The current issues
The main issues now related to the
TableManager
's code in lines967-993
:971-973
isn't true.Related tests failures:
org.apache.ignite.internal.table.distributed.TableManagerRecoveryTest
Probably, the reason of failure for two following tests is
null
somewhere aroundReplicaManager:L679
.testTableIgnoredOnRecovery
testTableStartedOnRecovery
org.apache.ignite.internal.rebalance.ItRebalanceDistributedTest
testRebalanceWithTheSameNodes
The reason of failure is point 2 of main issues: we should start replica only once per node
org.apache.ignite.internal.disaster.ItDisasterRecoveryReconfigurationTest
Both of failed tests
testManualRebalanceIfPartitionIsLost
andtestManualRebalanceIfMajorityIsLost
are unfamiliar and unclear now for me. The common reason is somewhat like:But I'm sure that isn't the root cause.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes