Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-17511. method storagespaceConsumedContiguous should use BlockInfo#getReplication to compute dsDelta. #6799

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

hfutatzhanghb
Copy link
Contributor

Description of PR

Refer to HDFS-17511.
We should use BlockInfo#getReplication to compute storage space in method INodeFile#storagespaceConsumedContiguous.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 00s No case conflicting files found.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 00s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 92m 03s trunk passed
+1 💚 compile 6m 31s trunk passed
+1 💚 checkstyle 4m 53s trunk passed
+1 💚 mvnsite 7m 11s trunk passed
+1 💚 javadoc 6m 05s trunk passed
+1 💚 shadedclient 152m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 6m 07s the patch passed
+1 💚 compile 3m 44s the patch passed
+1 💚 javac 3m 44s the patch passed
+1 💚 blanks 0m 00s The patch has no blanks issues.
+1 💚 checkstyle 2m 26s the patch passed
+1 💚 mvnsite 4m 14s the patch passed
+1 💚 javadoc 3m 38s the patch passed
+1 💚 shadedclient 165m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 5m 27s The patch does not generate ASF License warnings.
439m 12s
Subsystem Report/Notes
GITHUB PR #6799
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname MINGW64_NT-10.0-17763 1e88a5f1d281 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 2745319
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6799/1/testReport/
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6799/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hfutatzhanghb
Copy link
Contributor Author

@Hexiaoqiao @zhangshuyan0 @tomscut @haiyang1987 Sir, plz help me review this PR when you have free time~ Thanks a lot.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a UT covering change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants