-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17486. Unify the logic of the dumpXattrs method #6797
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
The test class TestOfflineImageViewer already exists. |
Description of PR
For more information about this PR, please refer to the following issue:
[HDFS-17486] (https://issues.apache.org/jira/browse/HDFS-17486)
VIO: dumpXattrs logic optimization
How was this patch tested?
The test class TestOfflineImageViewer already exists.TestOfflineImageViewer.testPBImageXmlWriter() method will call dumpXattrs when input parameter of dumpXattrs has xattrs.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?