YARN-11694. Fixed non-idempotent unit tests in the Yarn Module #6793

kaiyaok2 · 2024-05-04T05:40:01Z

Description of PR

This PR fixes non-idempotent unit tests detected in the Yarn module. These tests pass in the first run but fails in the second run in the same JVM.

TestTimelineReaderMetrics.testTimelineReaderMetrics()

org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderMetrics#testTimelineReaderMetrics does not perform a source unregistration after test execution, so the TimelineReaderMetrics.getInstance() call in repeated runs will throw an error since the metrics source TimelineReaderMetrics already exists.
Error message in the 2nd run:

org.apache.hadoop.metrics2.MetricsException: Metrics source TimelineReaderMetrics already exists!

Fix: Unregister "TimelineReaderMetrics" before the test.

TestFederationStateStoreClientMetrics.testSuccessfulCalls()

org.apache.hadoop.yarn.server.federation.store.metrics.TestFederationStateStoreClientMetrics#testSuccessfulCalls retrieves the historical number of successful calls, but does not retrieve the historical average latency of those calls. For example, it asserts FederationStateStoreClientMetrics.getLatencySucceededCalls() is 100 after the goodStateStore.registerSubCluster(100); call. However, in the second execution of the test, 2 historical calls from the first execution (with latency 100 and 200 respectively) has already been recorded, so FederationStateStoreClientMetrics.getLatencySucceededCalls() will be 133.33... (mean of 100, 200 and 100)
Error message in the 2nd run:

java.lang.AssertionError: expected:<100.0> but was:<133.33333333333334>

Fix: Retrieve existing latency data and use them for calculation.

All tests in TestTaskRunner

All tests in org.apache.hadoop.yarn.sls.scheduler.TestTaskRunner are not idempotent and fails upon repeated execution within the same JVM instance due to self-induced state pollution. Specifically, the test runs made changes to the static fields (e.g. PreStartTask.first in the task classes without restoring them. Therefore, repeated runs throw assertion errors.

Sample error message of TestTaskRunner#testPreStartQueueing in repeated test run:

java.lang.AssertionError:
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.apache.hadoop.yarn.sls.scheduler.TestTaskRunner.testPreStartQueueing(TestTaskRunner.java:244)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

The fix is done by explicitly setting (resetting) the static variables (countdown latches and booleans) at the start of each test, so that each test runs on a fresh state.

How was this patch tested?

After the patch, rerunning the tests in the same JVM does not produce any exceptions.

hadoop-yetus · 2024-05-04T07:17:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 32s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 40s		trunk passed
+1 💚	compile	1m 28s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	1m 17s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	checkstyle	0m 44s		trunk passed
+1 💚	mvnsite	0m 50s		trunk passed
+1 💚	javadoc	0m 52s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	0m 46s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	1m 26s		trunk passed
+1 💚	shadedclient	19m 52s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 34s		the patch passed
+1 💚	compile	1m 18s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	1m 18s		the patch passed
+1 💚	compile	1m 8s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	javac	1m 8s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	mvnsite	0m 39s		the patch passed
+1 💚	javadoc	0m 34s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	0m 37s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	1m 32s		the patch passed
+1 💚	shadedclient	19m 37s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 44s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	1m 13s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		96m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/1/artifact/out/Dockerfile
GITHUB PR	#6793
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 235fa8be1bd7 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c93cf85`
Default Java	Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/1/testReport/
Max. process+thread count	551 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2024-05-04T09:48:12Z

@kaiyaok2 Thank you for your contribution! but it does indeed introduce some noise (I have already seen at least 4 similar pull requests). Can we find all the relevant issues and fix them together?

kaiyaok2 · 2024-05-04T16:06:12Z

@kaiyaok2 Thank you for your contribution! but it does indeed introduce some noise (I have already seen at least 4 similar pull requests). Can we find all the relevant issues and fix them together?

@slfan1989 Thanks for reviewing! I merged changes in #6794 to this PR (#6793). Now all fixes to the MapReduce module are in #6785 , and all fixes to the Yarn module are in this PR (#6793).

hadoop-yetus · 2024-05-04T18:35:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	20m 3s		trunk passed
+1 💚	compile	8m 48s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	8m 6s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	checkstyle	2m 10s		trunk passed
+1 💚	mvnsite	1m 40s		trunk passed
+1 💚	javadoc	1m 34s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 35s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	2m 26s		trunk passed
+1 💚	shadedclient	20m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 48s		the patch passed
+1 💚	compile	8m 27s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	8m 27s		the patch passed
+1 💚	compile	8m 4s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	javac	8m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 59s	/results-checkstyle-root.txt	root: The patch generated 7 new + 10 unchanged - 5 fixed = 17 total (was 15)
+1 💚	mvnsite	1m 34s		the patch passed
+1 💚	javadoc	1m 30s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 33s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	2m 51s		the patch passed
+1 💚	shadedclient	20m 35s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 55s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	1m 27s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	unit	11m 49s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		152m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/2/artifact/out/Dockerfile
GITHUB PR	#6793
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 6e3842f831ce 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `6615599`
Default Java	Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/2/testReport/
Max. process+thread count	552 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-tools/hadoop-sls U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2024-05-06T04:11:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 26s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 55s		trunk passed
+1 💚	compile	8m 46s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	8m 7s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	checkstyle	2m 12s		trunk passed
+1 💚	mvnsite	1m 37s		trunk passed
+1 💚	javadoc	1m 38s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 34s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	2m 31s		trunk passed
+1 💚	shadedclient	20m 46s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 49s		the patch passed
+1 💚	compile	8m 27s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	8m 27s		the patch passed
+1 💚	compile	8m 3s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	javac	8m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 59s	/results-checkstyle-root.txt	root: The patch generated 7 new + 10 unchanged - 5 fixed = 17 total (was 15)
+1 💚	mvnsite	1m 29s		the patch passed
+1 💚	javadoc	1m 22s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 32s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	2m 46s		the patch passed
+1 💚	shadedclient	20m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 58s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	1m 25s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	unit	11m 50s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		151m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/3/artifact/out/Dockerfile
GITHUB PR	#6793
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux e323692159cd 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ef37ee4`
Default Java	Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/3/testReport/
Max. process+thread count	551 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-tools/hadoop-sls U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2024-05-06T23:53:56Z

+1 Can we fix the checkstyle issue?

hadoop-yetus · 2024-05-07T07:52:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	13m 48s		Maven dependency ordering for branch
+1 💚	mvninstall	21m 55s		trunk passed
+1 💚	compile	9m 36s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	compile	9m 12s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	checkstyle	2m 16s		trunk passed
+1 💚	mvnsite	1m 19s		trunk passed
+1 💚	javadoc	1m 19s		trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 15s		trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	2m 4s		trunk passed
+1 💚	shadedclient	22m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 24s		Maven dependency ordering for patch
+1 💚	mvninstall	0m 44s		the patch passed
+1 💚	compile	9m 48s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javac	9m 48s		the patch passed
+1 💚	compile	8m 59s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	javac	8m 59s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	2m 23s	/results-checkstyle-root.txt	root: The patch generated 5 new + 10 unchanged - 5 fixed = 15 total (was 15)
+1 💚	mvnsite	1m 19s		the patch passed
+1 💚	javadoc	1m 16s		the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚	javadoc	1m 13s		the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚	spotbugs	2m 22s		the patch passed
+1 💚	shadedclient	22m 34s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 18s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	1m 7s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	unit	11m 42s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		157m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/4/artifact/out/Dockerfile
GITHUB PR	#6793
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ffac63be2731 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `48194ae`
Default Java	Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/4/testReport/
Max. process+thread count	721 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-tools/hadoop-sls U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6793/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

kaiyaok2 · 2024-05-07T08:20:06Z

+1 Can we fix the checkstyle issue?

@slfan1989 I fixed the 2 "line too long" issues.
The remaining 5 are in fact existing issues (as I changed public static CountDownLatch latch = new CountDownLatch(1); to public static CountDownLatch latch;). I don't think it's necessary to turn latch private and add getter methods, since these classes are only used in testing.

hadoop-yetus · 2024-05-08T05:19:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
			_ Prechecks _
+1 💚	dupname	0m 01s		No case conflicting files found.
+0 🆗	spotbugs	0m 00s		spotbugs executables are not available.
+0 🆗	codespell	0m 00s		codespell was not available.
+0 🆗	detsecrets	0m 01s		detect-secrets was not available.
+1 💚	@author	0m 00s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 00s		The patch appears to include 3 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	3m 50s		Maven dependency ordering for branch
+1 💚	mvninstall	90m 53s		trunk passed
+1 💚	compile	41m 07s		trunk passed
+1 💚	checkstyle	6m 01s		trunk passed
+1 💚	mvnsite	14m 06s		trunk passed
+1 💚	javadoc	13m 58s		trunk passed
+1 💚	shadedclient	170m 11s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	2m 37s		Maven dependency ordering for patch
+1 💚	mvninstall	8m 42s		the patch passed
+1 💚	compile	38m 25s		the patch passed
+1 💚	javac	38m 25s		the patch passed
+1 💚	blanks	0m 00s		The patch has no blanks issues.
+1 💚	checkstyle	6m 02s		the patch passed
+1 💚	mvnsite	14m 24s		the patch passed
+1 💚	javadoc	13m 47s		the patch passed
+1 💚	shadedclient	180m 14s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	5m 39s		The patch does not generate ASF License warnings.
		547m 46s

Subsystem	Report/Notes
GITHUB PR	#6793
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	MINGW64_NT-10.0-17763 9beec3ff0f2e 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool	maven
Personality	/c/hadoop/dev-support/bin/hadoop.sh
git revision	trunk / `48194ae`
Default Java	Azul Systems, Inc.-1.8.0_332-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6793/1/testReport/
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-tools/hadoop-sls U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6793/1/console
versions	git=2.44.0.windows.1
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

fixed non-idempotent unit tests

c93cf85

github-actions bot added YARN trunk labels May 4, 2024

kaiyaok2 mentioned this pull request May 4, 2024

YARN-11695. Fixed non-idempotent unit tests in TestTaskRunner #6794

Closed

github-actions bot added the TOOLS label May 4, 2024

kaiyaok2 changed the title ~~YARN-11694. Fixed 2 non-idempotent unit tests~~ YARN-11694. Fixed non-idempotent unit tests in the Yarn Module May 4, 2024

kaiyaok2 force-pushed the NIO_yarn branch from 6615599 to ef37ee4 Compare May 6, 2024 01:39

fixed all non-idempotent unit tests

48194ae

kaiyaok2 force-pushed the NIO_yarn branch from ef37ee4 to 48194ae Compare May 7, 2024 05:14

slfan1989 approved these changes May 8, 2024

View reviewed changes

kaiyaok2 mentioned this pull request May 18, 2024

MAPREDUCE-7475. Fixed non-idempotent unit tests #6785

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11694. Fixed non-idempotent unit tests in the Yarn Module #6793

YARN-11694. Fixed non-idempotent unit tests in the Yarn Module #6793

kaiyaok2 commented May 4, 2024 •

edited

hadoop-yetus commented May 4, 2024

slfan1989 commented May 4, 2024

kaiyaok2 commented May 4, 2024 •

edited

hadoop-yetus commented May 4, 2024

hadoop-yetus commented May 6, 2024

slfan1989 commented May 6, 2024

hadoop-yetus commented May 7, 2024

kaiyaok2 commented May 7, 2024

hadoop-yetus commented May 8, 2024

YARN-11694. Fixed non-idempotent unit tests in the Yarn Module #6793

Are you sure you want to change the base?

YARN-11694. Fixed non-idempotent unit tests in the Yarn Module #6793

Conversation

kaiyaok2 commented May 4, 2024 • edited

Description of PR

TestTimelineReaderMetrics.testTimelineReaderMetrics()

TestFederationStateStoreClientMetrics.testSuccessfulCalls()

All tests in TestTaskRunner

How was this patch tested?

hadoop-yetus commented May 4, 2024

slfan1989 commented May 4, 2024

kaiyaok2 commented May 4, 2024 • edited

hadoop-yetus commented May 4, 2024

hadoop-yetus commented May 6, 2024

slfan1989 commented May 6, 2024

hadoop-yetus commented May 7, 2024

kaiyaok2 commented May 7, 2024

hadoop-yetus commented May 8, 2024

kaiyaok2 commented May 4, 2024 •

edited

kaiyaok2 commented May 4, 2024 •

edited