-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16710. Remove redundant throw exceptions in org.apache.hadoop.hdfs.server.namenode package #4670
base: trunk
Are you sure you want to change the base?
Conversation
@@ -36,9 +36,9 @@ public static void set(CheckpointFaultInjector instance) { | |||
CheckpointFaultInjector.instance = instance; | |||
} | |||
public void beforeGetImageSetsHeaders() throws IOException {} | |||
public void afterSecondaryCallsRollEditLog() throws IOException {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the source for so many wrong definitions?
LGTM. |
💔 -1 overall
This message was automatically generated. |
@ZanderXu We need to pay attention to checkstyle, and then see if the junit test problem is related to this change. Thank you. |
|
@slfan1989 Sir, I have updated the patch to fix the checkstyle, please help me review it again. Thanks |
💔 -1 overall
This message was automatically generated. |
LGTM. |
@goiri Hi, Master, can help me merge this pr into trunk? Thank you very much. |
@goiri @slfan1989 Masters, I have rebased this PR on the latest trunk. Sorry to ping you to help me merge this to trunk. I think it is helpful for the simplicity of the code. If you agree it, please help me to merge it into the trunk. Else let me close this PR. Thanks again. |
💔 -1 overall
This message was automatically generated. |
…fs.server.namenode package
💔 -1 overall
This message was automatically generated. |
Description of PR
When I read some class about HDFS NameNode, I found there are many redundant throw exception in org.apahce.hadoop.hdfs.server.namenode package, such as:
Because ServiceFailedException and AccessControlException is subClass of IOException, so I feel that ServiceFailedException and AccessControlException are redundant, so we can remove it to make code clearer, such as: