GUACAMOLE-1658: Remove reference to non-existing ssh_key header. #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to a draft for the moment - this needs a bit more work to fix the other issues that are present because of it. |
|
Are there still issues with this PR? It looks pretty straightforward, and the issue appears to be still valid as well. |
|
@jmuehlner Yeah, unfortunately this is going to require re-implementing the overall SSH agent/key support that got removed. There are notes in the Jira issue - https://issues.apache.org/jira/browse/GUACAMOLE-1658. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the reference to the non-existent
ssh_key.hfile, which breaks when you try to build with SSH agent support (--enable-ssh-agent).Submitting this is a bug fix to 1.5.4.