Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUACAMOLE-600: Add support for setting SSH and SFTP timeouts. #414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GUACAMOLE-600: Add support for setting SSH and SFTP timeouts. #414

wants to merge 2 commits into from

Conversation

necouchman
Copy link
Contributor

This pull request adds support for setting the connection timeout for SSH and SFTP connections via connection parameters.

jmuehlner
jmuehlner reviewed May 24, 2024
View reviewed changes
src/common-ssh/ssh.c Outdated Show resolved Hide resolved
@necouchman necouchman force-pushed the jira/GUACAMOLE-600-SSH branch 2 times, most recently from 313abee to e08ff9f Compare May 24, 2024 18:53
@necouchman necouchman marked this pull request as draft May 24, 2024 18:55
@necouchman
Copy link
Contributor Author

Actually, converting this back to a draft. Since I used a previous change to collect the common socket code together in a single place, this needs to be reworked a bit...

@necouchman necouchman force-pushed the jira/GUACAMOLE-600-SSH branch 2 times, most recently from b07b3b4 to 8812c79 Compare May 25, 2024 01:34
@necouchman
Copy link
Contributor Author

Okay, I think this is ready, again, for review.

@necouchman necouchman marked this pull request as ready for review May 25, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmuehlner jmuehlner jmuehlner left review comments

@mike-jumper mike-jumper Awaiting requested review from mike-jumper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@necouchman @jmuehlner