GUACAMOLE-1611: Improve FR translations and add missings ones #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Thanks @corentin-soriano, very much appreciate the assistance with these translations! A few issues to correct, here, before it gets committed...
| "ACTION_CANCEL" : "@:APP.ACTION_CANCEL", | ||
| "ACTION_CLEAR_CLIENT_MESSAGES" : "@:APP.ACTION_CLEAR", | ||
| "ACTION_CLEAR_COMPLETED_TRANSFERS" : "@:APP.ACTION_CLEAR", | ||
| "ACTION_CONTINUE" : "@:APP.ACTION_CONTINUE", |
There was a problem hiding this comment.
I can't remember exactly how these work, but I didn't think it was necessary to include all of the references to other sections/translations - I thought that, this, too, would be inherited from the English translation. But, I can't remember if that results in things being translated in English or the intended language...
There was a problem hiding this comment.
I've seen them in various places, so I preferred to add them for consistency with the rest of the file.
No problem removing them if you prefer.
corentin-soriano
force-pushed
the
GUACAMOLE-1611_fr_translations
branch
from
22a40c8
to
8f5849a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction/improvement of French translations.
Addition of missing translations.