Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1685: Optimize Dockerfile layering by minimizing run statem… #763

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pbuehl-redhat
Copy link

…ents

Copy link
Contributor

@mike-jumper mike-jumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. These changes appear to reduce the layer count by 1, at the expense of causing a full rebuild any time a build param is changed. Can you cite anything behind why you want to make these changes?
  2. Please make sure your commits cover the high-level need behind the change being made (or are squashed into a commit that does). The commit "GUACAMOLE-1685: Add extra fix" does not add any information useful to the git history. See this helpful blog post: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants