Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT DO NOT REVIEW] WAN transactions extracted to module #7810

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

albertogpz
Copy link
Contributor

commit 4ce6664
Author: Alberto Gomez alberto.gomez@est.tech
Date: Tue Dec 14 19:30:37 2021 +0100

Fix tests

commit 77db403
Author: Alberto Gomez alberto.gomez@est.tech
Date: Tue Dec 14 18:43:41 2021 +0100

Added exceptions to public API changes

commit 8c2f77d
Author: Alberto Gomez alberto.gomez@est.tech
Date: Tue Dec 14 17:52:24 2021 +0100

Use --type=TxGroupingParallelGatewaySender... as suggested in jbarrett's review

commit cbe859d
Author: Alberto Gomez alberto.gomez@est.tech
Date: Mon Dec 13 12:36:50 2021 +0100

remove() refactored as suggested on jbarrett's review

commit 43194d0
Author: Alberto Gomez alberto.gomez@est.tech
Date: Thu Dec 2 06:52:38 2021 +0100

Updated with Kirk's first review comments

commit 0c3d814
Author: Alberto Gomez alberto.gomez@est.tech
Date: Fri Nov 5 08:16:10 2021 +0100

MODULE: Add gfsh create tx-grouping gw-sender cases.

commit a7416a3
Author: Alberto Gomez alberto.gomez@est.tech
Date: Fri Nov 5 08:15:46 2021 +0100

MODULE: Do not allow changing group-transaction-events

commit 74f9274
Author: Alberto Gomez alberto.gomez@est.tech
Date: Fri Nov 5 08:15:28 2021 +0100

MODULE: Fix some GatewaySenderFactoryImpl tests

commit 1959233
Author: Alberto Gomez alberto.gomez@est.tech
Date: Fri Nov 5 08:13:54 2021 +0100

MODULE: Move remaining tx-grouping functionality and DUnit tests

commit 5aa6bc7
Author: Jacob Barrett jbarrett@pivotal.io
Date: Wed Oct 13 19:50:56 2021 -0700

MODULE: Move tests

commit 07884e8
Author: Jacob Barrett jbarrett@pivotal.io
Date: Wed Oct 13 19:24:12 2021 -0700

MODULE: ServiceLoader

commit 0be467b
Author: Jacob Barrett jbarrett@pivotal.io
Date: Wed Oct 13 16:31:02 2021 -0700

MODULE: Stupid simple module.

commit 477a823
Author: Jacob Barrett jbarrett@pivotal.io
Date: Wed Oct 13 16:08:08 2021 -0700

MODULE: Remove AbstractGatwaySender.mustGroupTransactionEvents()

commit f7c0d21
Author: Jacob Barrett jbarrett@pivotal.io
Date: Wed Oct 13 14:14:38 2021 -0700

MODULE: Create TX grouping sender impls.

commit 35b072e
Author: Jacob Barrett jbarrett@pivotal.io
Date: Wed Oct 13 14:01:04 2021 -0700

MODULE: Extract out TX grouping factories.

commit 7a3d45c
Author: Jacob Barrett jbarrett@pivotal.io
Date: Wed Oct 13 13:19:15 2021 -0700

MODULE: Split out some factories.

commit ae74a42
Author: Jacob Barrett jbarrett@pivotal.io
Date: Thu Sep 30 15:24:56 2021 -0700

MODULE: Extract interface for GatewaySenderAttributes.

commit 8c2d23e
Author: Jacob Barrett jbarrett@pivotal.io
Date: Thu Sep 30 17:22:04 2021 -0700

GEODE-6588: Cleanup GatewaySenderFactoryImpl

commit 2457963
Author: Jacob Barrett jbarrett@pivotal.io
Date: Thu Sep 30 16:07:40 2021 -0700

GEODE-6588: Cleanup AbstractGatewaySender

commit 042013d
Author: Jacob Barrett jbarrett@pivotal.io
Date: Thu Sep 30 14:54:03 2021 -0700

GEODE-6588: Cleanup GatewaySenderAttributes

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@albertogpz albertogpz force-pushed the wip/wan-tx-grouping-module_squashed branch from fca45a7 to 422ba31 Compare June 17, 2022 11:47
commit 4ce6664
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Tue Dec 14 19:30:37 2021 +0100

    Fix tests

commit 77db403
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Tue Dec 14 18:43:41 2021 +0100

    Added exceptions to public API changes

commit 8c2f77d
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Tue Dec 14 17:52:24 2021 +0100

    Use --type=TxGroupingParallelGatewaySender... as suggested in jbarrett's review

commit cbe859d
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Mon Dec 13 12:36:50 2021 +0100

    remove() refactored as suggested on jbarrett's review

commit 43194d0
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Thu Dec 2 06:52:38 2021 +0100

    Updated with Kirk's first review comments

commit 0c3d814
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Fri Nov 5 08:16:10 2021 +0100

    MODULE: Add gfsh create tx-grouping gw-sender cases.

commit a7416a3
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Fri Nov 5 08:15:46 2021 +0100

    MODULE: Do not allow changing group-transaction-events

commit 74f9274
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Fri Nov 5 08:15:28 2021 +0100

    MODULE: Fix some GatewaySenderFactoryImpl tests

commit 1959233
Author: Alberto Gomez <alberto.gomez@est.tech>
Date:   Fri Nov 5 08:13:54 2021 +0100

    MODULE: Move remaining tx-grouping functionality and DUnit tests

commit 5aa6bc7
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Wed Oct 13 19:50:56 2021 -0700

    MODULE: Move tests

commit 07884e8
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Wed Oct 13 19:24:12 2021 -0700

    MODULE: ServiceLoader

commit 0be467b
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Wed Oct 13 16:31:02 2021 -0700

    MODULE: Stupid simple module.

commit 477a823
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Wed Oct 13 16:08:08 2021 -0700

    MODULE: Remove AbstractGatwaySender.mustGroupTransactionEvents()

commit f7c0d21
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Wed Oct 13 14:14:38 2021 -0700

    MODULE: Create TX grouping sender impls.

commit 35b072e
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Wed Oct 13 14:01:04 2021 -0700

    MODULE: Extract out TX grouping factories.

commit 7a3d45c
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Wed Oct 13 13:19:15 2021 -0700

    MODULE: Split out some factories.

commit ae74a42
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Thu Sep 30 15:24:56 2021 -0700

    MODULE: Extract interface for GatewaySenderAttributes.

commit 8c2d23e
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Thu Sep 30 17:22:04 2021 -0700

    GEODE-6588: Cleanup GatewaySenderFactoryImpl

commit 2457963
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Thu Sep 30 16:07:40 2021 -0700

    GEODE-6588: Cleanup AbstractGatewaySender

commit 042013d
Author: Jacob Barrett <jbarrett@pivotal.io>
Date:   Thu Sep 30 14:54:03 2021 -0700

    GEODE-6588: Cleanup GatewaySenderAttributes
@albertogpz albertogpz force-pushed the wip/wan-tx-grouping-module_squashed branch from 422ba31 to 22fad08 Compare June 17, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant