Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34993] parser changes to support model CRUD sql #24769

Merged
merged 1 commit into from May 27, 2024

Conversation

lihaosky
Copy link
Contributor

What is the purpose of the change

Support model CRUD sql syntax

Brief change log

Add following syntax for model

  • create model
  • drop model
  • show model
  • show create model
  • alter model

Verifying this change

Unit test for parser

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (n)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@lihaosky
Copy link
Contributor Author

cc @twalthr , @wuchong

@flinkbot
Copy link
Collaborator

flinkbot commented May 10, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @lihaosky. I added some comments. Esp. the support for temporary and error behavior for missing implementation should be solved before merging this.

@lihaosky
Copy link
Contributor Author

@twalthr , does this repo have CI build? I can't see it

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly adjusted some names for consistency in the code base. Otherwise this LGTM. I will merge this once the build is green.

@twalthr twalthr merged commit 4d39738 into apache:master May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants