New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34993] parser changes to support model CRUD sql #24769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @lihaosky. I added some comments. Esp. the support for temporary and error behavior for missing implementation should be solved before merging this.
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateModel.java
Outdated
Show resolved
Hide resolved
...k-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateModelAs.java
Outdated
Show resolved
Hide resolved
...ble/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlRichDescribeModel.java
Outdated
Show resolved
Hide resolved
...table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
Show resolved
Hide resolved
...k-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkPlannerImpl.scala
Show resolved
Hide resolved
@twalthr , does this repo have CI build? I can't see it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly adjusted some names for consistency in the code base. Otherwise this LGTM. I will merge this once the build is green.
What is the purpose of the change
Support model CRUD sql syntax
Brief change log
Add following syntax for model
create model
drop model
show model
show create model
alter model
Verifying this change
Unit test for parser
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation