Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a refactoring to simplify prototype reference access #159

Open
wants to merge 10,000 commits into
base: trunk
Choose a base branch
from
Open

Provide a refactoring to simplify prototype reference access #159

wants to merge 10,000 commits into from

Conversation

timothyjward
Copy link
Contributor

This should also Fix FELIX-5974

Signed-off-by: Tim Ward timothyjward@apache.org

cschneider and others added 30 commits July 12, 2018 09:32
@cschneider
Updated docs
5c22212 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835711 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Improve servlet docs
ba0771c 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835720 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Improve servlet docs
c1ffb33 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835722 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Add rat plugin config
2cde23a 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835747 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Add javadoc config
050df93 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835748 13f79535-47bb-0310-9956-ffa450edef68
Switch to felix parent, add scm entry, add signature config for java 8
4bae72d 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835750 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5885 : SCR uses an overly restrictive import range for promises
fa1bd84 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835788 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Move why systemready and add project information
3d01deb 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835793 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
[maven-release-plugin] prepare release org.apache.felix.systemready-0…
f2b6d7e 
….2.0

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835795 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
[maven-release-plugin] prepare for next development iteration
1ba0c04 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835797 13f79535-47bb-0310-9956-ffa450edef68
@karlpauls
FELIX-5886: Only log errors if we can't load the bytes of an existing…
cd3dbb5 
… entry and not if the entry doesn't exist at all.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1835798 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Simplify pom.xml
894c1aa 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836044 13f79535-47bb-0310-9956-ffa450edef68
@karlpauls
FELIX-5889: make extension bundle capabilities be indexed by the reso…
3c147cb 
…lver.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836072 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Add comment
f638feb 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836084 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Add build status
5539b4f 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836098 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Remove test results badge as it does not work
d96bfe6 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836100 13f79535-47bb-0310-9956-ffa450edef68
@karlpauls
Clean-up: use StringBuilder instead of StringBuffer everywhere.
6ee15de 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836153 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5891 : Keep order of properties and objects. Apply patch from A…
e511497 
…ndrei Tuicu

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836628 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5891 : Keep order of properties and objects. Apply patch from A…
6ace05b 
…ndrei Tuicu

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836629 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5891 : Keep order of properties and objects. Apply patch from A…
63cc337 
…ndrei Tuicu

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836630 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
[maven-release-plugin] prepare release org.apache.felix.configurator-…
3748360 
…1.0.2

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836695 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
[maven-release-plugin] prepare for next development iteration
bcd3ee6 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836697 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5892 : Repeated calls to getFactoryConfiguration return differe…
3a06422 
…nt configuration instances. Apply patch from Tim Ward

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1836873 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
Update changelog
6413784 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837113 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
[maven-release-plugin] prepare release org.apache.felix.configadmin-1…
926be00 
….9.4

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837114 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
[maven-release-plugin] prepare for next development iteration
bb983d2 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837116 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
Update changelog
13fa2ee 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837276 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
[maven-release-plugin] prepare release org.apache.felix.scr-2.1.2
da57a51 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837277 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
[maven-release-plugin] prepare for next development iteration
6744029 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837279 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5896 : Avoid runtime dependency to javax.annotation package
5c12c07 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1837291 13f79535-47bb-0310-9956-ffa450edef68
cschneider and others added 27 commits October 11, 2018 20:48
@cschneider
Add local repo config
91fa11e 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843602 13f79535-47bb-0310-9956-ffa450edef68
Ignore downloded index.html.tmp file. Removed "--ignore-length --no-c…
915b319 
…heck-certificate"

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843603 13f79535-47bb-0310-9956-ffa450edef68
Fixed commitToStaging task which should use the --force-interactive o…
b33eee4 
…ption when running svn import command. This ensures that svn credentials can be asked if needed.

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843604 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Add local repo config
6480e08 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843605 13f79535-47bb-0310-9956-ffa450edef68
@cschneider
Add local repo config
a4f2710 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843606 13f79535-47bb-0310-9956-ffa450edef68
@karlpauls
FELIX-5964: Make tls work with anonymous pages by registering the fil…
a087200 
…ter as Preprocessor with the whiteboard (patch provided by Antonio Sanso - thanks)

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843662 13f79535-47bb-0310-9956-ffa450edef68
@karlpauls
[maven-release-plugin] prepare release org.apache.felix.http.sslfilte…
149a5e5 
…r-1.2.6

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843663 13f79535-47bb-0310-9956-ffa450edef68
@karlpauls
[maven-release-plugin] prepare for next development iteration
d4fe41b 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843665 13f79535-47bb-0310-9956-ffa450edef68
@karlpauls
Require osgi.http to be version >=1.1
c19f3dc 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843668 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[configadmin] update changelog
7148d78 
Signed-off-by: Raymond Auge <rotty3000@apache.org>

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843781 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[maven-release-plugin] prepare release org.apache.felix.configadmin-1…
873a778 
….9.10

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843782 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[maven-release-plugin] prepare for next development iteration
1de4103 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843784 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[maven-release-plugin] prepare release org.apache.felix.scr-2.1.12
0702828 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843794 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[maven-release-plugin] prepare for next development iteration
9edc3df 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843796 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5950 : NPE in MultiplePrototypeRefPair.unsetServiceObject
de57257 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1843926 13f79535-47bb-0310-9956-ffa450edef68
FELIX-5967: DM does not support java9+
a27ba28 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844108 13f79535-47bb-0310-9956-ffa450edef68
FELIX-5336: fixed bug where a prototype scope component is instantiat…
21e9b5d 
…ed unexpectedly. Do not instantiate prototype instance in case the component does not have an init method

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844112 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5950 : NPE in MultiplePrototypeRefPair.unsetServiceObject
061a17b 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844202 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
FELIX-5969 remove transitive dependencies from gogo command
0ed62a7 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844262 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[maven-bundle-plugin] Prep for bndlib 4.1.0
aaaacaa 
Signed-off-by: Raymond Auge <rotty3000@apache.org>

git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844267 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[maven-release-plugin] prepare release maven-bundle-plugin-4.1.0
3b0309d 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844269 13f79535-47bb-0310-9956-ffa450edef68
@rotty3000
[maven-release-plugin] prepare for next development iteration
8f297f7 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844271 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
FELIX-5966 : NPE at RuntimeDTOBuilder.java:74
acb085c 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844307 13f79535-47bb-0310-9956-ffa450edef68
@cziegeler
Update to parent pom 6
e0c50cf 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844308 13f79535-47bb-0310-9956-ffa450edef68
Added force-interactive option when doing promotion.
291658c 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844536 13f79535-47bb-0310-9956-ffa450edef68
Configure baselone on dependency manager r12 artifacts
64d677e 
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk@1844600 13f79535-47bb-0310-9956-ffa450edef68
@timothyjward
Provide a refactoring to simplify prototype reference access
1a0973e 
This should also Fix FELIX-5974

Signed-off-by: Tim Ward <timothyjward@apache.org>
@timothyjward
Copy link
Contributor Author

Note that I couldn't work out how the SCR tests work. I don't know how things like this are normally tested, and I will need help to supply tests for this change.

@timothyjward
Ensure that RefPair references are released
cc82fa1 
Closing a ComponentContext should release the services that it accesses to avoid a memory leak

Signed-off-by: Tim Ward <timothyjward@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
8 participants
@timothyjward @cschneider @cziegeler @karlpauls @dulvac @rotty3000 @bosschaert @tjwatson