Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4174]Support to subscribe message by tags when using RocketMQ storage plugin. #4175

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pandaapo
Copy link
Contributor

@pandaapo pandaapo commented Jul 2, 2023

Fixes #4174.

Motivation

Support to subscribe tcp message by tags when using RocketMQ storage plugin.

Modifications

Add api based on RocketMQ message tag related api to implement subscribing tcp message by tags when using RocketMQ storage plugin.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (378aa75) 17.62% compared to head (6152f52) 17.59%.

Files Patch % Lines
...ache/eventmesh/client/tcp/common/MessageUtils.java 11.76% 15 Missing ⚠️
...nt/tcp/impl/cloudevent/CloudEventTCPSubClient.java 0.00% 12 Missing ⚠️
...eventmeshmessage/EventMeshMessageTCPSubClient.java 0.00% 12 Missing ⚠️
...he/eventmesh/common/protocol/SubscriptionItem.java 0.00% 11 Missing ⚠️
.../protocol/tcp/client/group/ClientGroupWrapper.java 0.00% 6 Missing ⚠️
...ntmesh/storage/rocketmq/producer/ProducerImpl.java 45.45% 5 Missing and 1 partial ⚠️
...pache/eventmesh/client/tcp/EventMeshTCPClient.java 0.00% 4 Missing ⚠️
...he/eventmesh/client/tcp/EventMeshTCPSubClient.java 0.00% 4 Missing ⚠️
...pl/eventmeshmessage/EventMeshMessageTCPClient.java 0.00% 4 Missing ⚠️
...entmesh/runtime/core/plugin/MQConsumerWrapper.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4175      +/-   ##
============================================
- Coverage     17.62%   17.59%   -0.03%     
- Complexity     1784     1785       +1     
============================================
  Files           805      807       +2     
  Lines         29924    29985      +61     
  Branches       2580     2584       +4     
============================================
+ Hits           5273     5276       +3     
- Misses        24169    24227      +58     
  Partials        482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Alonexc
Alonexc previously approved these changes Jul 5, 2023
@qqeasonchen
Copy link
Contributor

any update?

@pandaapo
Copy link
Contributor Author

pandaapo commented Sep 4, 2023

any update?

There are no more updates for now.

@pandaapo
Copy link
Contributor Author

pandaapo commented Oct 30, 2023

PR description in Chinese

[Title] 当使用RocketMQ storage插件时,支持按照标签订阅消息。

Motivation

当使用RocketMQ storage插件时,支持按照标签订阅消息(tcp)。

Modifications

增加基于RocketMQ消息标签相关的api的接口,从而实现当用户使用RocketMQ storage插件时,可以按照标签订阅消息(tcp)。

@xwm1992
Copy link
Contributor

xwm1992 commented Jan 26, 2024

@pandaapo please solve the conflicts.

@pandaapo
Copy link
Contributor Author

@pandaapo please solve the conflicts.

Conflicts fixed.

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.04598% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 17.59%. Comparing base (378aa75) to head (6152f52).
Report is 25 commits behind head on master.

Files Patch % Lines
...ache/eventmesh/client/tcp/common/MessageUtils.java 11.76% 15 Missing ⚠️
...nt/tcp/impl/cloudevent/CloudEventTCPSubClient.java 0.00% 12 Missing ⚠️
...eventmeshmessage/EventMeshMessageTCPSubClient.java 0.00% 12 Missing ⚠️
...he/eventmesh/common/protocol/SubscriptionItem.java 0.00% 11 Missing ⚠️
.../protocol/tcp/client/group/ClientGroupWrapper.java 0.00% 6 Missing ⚠️
...ntmesh/storage/rocketmq/producer/ProducerImpl.java 45.45% 5 Missing and 1 partial ⚠️
...pache/eventmesh/client/tcp/EventMeshTCPClient.java 0.00% 4 Missing ⚠️
...he/eventmesh/client/tcp/EventMeshTCPSubClient.java 0.00% 4 Missing ⚠️
...pl/eventmeshmessage/EventMeshMessageTCPClient.java 0.00% 4 Missing ⚠️
...entmesh/runtime/core/plugin/MQConsumerWrapper.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4175      +/-   ##
============================================
- Coverage     17.62%   17.59%   -0.03%     
- Complexity     1784     1785       +1     
============================================
  Files           805      807       +2     
  Lines         29924    29985      +61     
  Branches       2580     2584       +4     
============================================
+ Hits           5273     5276       +3     
- Misses        24169    24227      +58     
  Partials        482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pil0tXia
Copy link
Member

It seems that this PR could have been merged.

@github-actions github-actions bot removed the Stale label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support to subscribe message by tags when using RocketMQ storage plugin.
6 participants