-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unified integretion test for registry module #15981
Conversation
660c3f1
to
c586185
Compare
c586185
to
241f33f
Compare
b4fc90f
to
e747cfb
Compare
81a9ce0
to
5f6a635
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15981 +/- ##
============================================
+ Coverage 39.94% 40.39% +0.44%
- Complexity 5081 5174 +93
============================================
Files 1369 1378 +9
Lines 45643 46084 +441
Branches 4869 4923 +54
============================================
+ Hits 18232 18615 +383
- Misses 25513 25542 +29
- Partials 1898 1927 +29 ☔ View full report in Codecov by Sentry. |
30318c3
to
e2ed62f
Compare
e2ed62f
to
97031ca
Compare
5fa4895
to
293aa96
Compare
293aa96
to
c77b713
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of the pull request
Add base integration test for registry module, used to make sure all registry plugins are implemented correctly.
Brief change log
dolphinscheduler-registry-it
Verify this pull request
Verify by IT.