Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unified integretion test for registry module #15981

Merged
merged 1 commit into from
May 13, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 11, 2024

Purpose of the pull request

Add base integration test for registry module, used to make sure all registry plugins are implemented correctly.

Brief change log

  • Add dolphinscheduler-registry-it
  • Add it for with zookeeper/etcd/jdbc plugin
  • Unify the reentrant lock logic.
  • Turn off some log in maven build, reduce the log size in ci.
  • Remove failsafe plugin, execute IT when compile
  • Remove unused collect log in ci
  • Remove auto update lastUpdateTime at registry table, since it's hard to auto set lastUpdateTime at PG, so we need to manual set lastUpdateTime at code.

Verify this pull request

Verify by IT.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addRegistryIT branch 5 times, most recently from 660c3f1 to c586185 Compare May 11, 2024 03:40
@ruanwenjun ruanwenjun self-assigned this May 11, 2024
@ruanwenjun ruanwenjun changed the title Add IntegretionTest for registry module Add unified integretion test for registry module May 11, 2024
@github-actions github-actions bot removed the test label May 11, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 11, 2024
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label May 11, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addRegistryIT branch 4 times, most recently from b4fc90f to e747cfb Compare May 11, 2024 08:38
@ruanwenjun ruanwenjun requested a review from SbloodyS as a code owner May 11, 2024 08:38
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addRegistryIT branch 2 times, most recently from 81a9ce0 to 5f6a635 Compare May 11, 2024 08:58
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2024

Codecov Report

Attention: Patch coverage is 66.01307% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 40.39%. Comparing base (3446fd8) to head (6520272).

❗ Current head 6520272 differs from pull request most recent head c77b713. Consider uploading reports for the commit c77b713 to get more accurate results

Files Patch % Lines
...egistry/zookeeper/ZookeeperRegistryProperties.java 48.48% 7 Missing and 10 partials ⚠️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 56.25% 11 Missing and 3 partials ⚠️
...inscheduler/plugin/registry/jdbc/JdbcOperator.java 55.00% 7 Missing and 2 partials ⚠️
...uler/plugin/registry/jdbc/RegistryLockManager.java 76.19% 5 Missing ⚠️
...inscheduler/plugin/registry/etcd/EtcdRegistry.java 83.33% 3 Missing and 1 partial ⚠️
...inscheduler/plugin/registry/jdbc/JdbcRegistry.java 77.77% 2 Missing ⚠️
...ler/plugin/registry/jdbc/SubscribeDataManager.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15981      +/-   ##
============================================
+ Coverage     39.94%   40.39%   +0.44%     
- Complexity     5081     5174      +93     
============================================
  Files          1369     1378       +9     
  Lines         45643    46084     +441     
  Branches       4869     4923      +54     
============================================
+ Hits          18232    18615     +383     
- Misses        25513    25542      +29     
- Partials       1898     1927      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addRegistryIT branch 3 times, most recently from 30318c3 to e2ed62f Compare May 11, 2024 11:19
@github-actions github-actions bot added the CI&CD label May 11, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addRegistryIT branch 5 times, most recently from 5fa4895 to 293aa96 Compare May 12, 2024 06:02
Copy link

sonarcloud bot commented May 12, 2024

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM.

Copy link
Member

@qingwli qingwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 7c8fa9b into apache:dev May 13, 2024
63 of 64 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_addRegistryIT branch May 13, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants